search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 589 forks source link

Checkboxes do not work in firefox again #431

Closed MonstraG closed 2 years ago

MonstraG commented 3 years ago

Checkboxes do not check in firefox.

Version React 17.0.2 Rich-markdown-editor 11.6.4

Gif Left: chrome, right: firefox. Both most recent. 1

Desktop (please complete the following information):

tommoor commented 3 years ago

I cannot reproduce this behavior, my guess is you're hitting this issue with the wrong version of prosemirror-transform installed:

https://github.com/outline/rich-markdown-editor/issues/427

MonstraG commented 3 years ago

I've deleted package.lock and node_modules, added "prosemirror-transform": "1.2.5", to dependencies, and run npm install, it still doesn't work. Gonna make a repro now

MonstraG commented 3 years ago

I'm realising I should have also said this: npm is v7.7.6 and gives following on clear npm install:

npm WARN ERESOLVE overriding peer dependency
npm WARN Found: prosemirror-tables@1.1.1
npm WARN node_modules/prosemirror-tables
npm WARN   prosemirror-tables@"^1.1.1" from rich-markdown-editor@11.6.4
npm WARN   node_modules/rich-markdown-editor
npm WARN     rich-markdown-editor@"^11.6.4" from the root project
npm WARN
npm WARN Could not resolve dependency:
npm WARN peer prosemirror-tables@"^0.9.1" from prosemirror-utils@0.9.6
npm WARN node_modules/prosemirror-utils
npm WARN   prosemirror-utils@"^0.9.6" from rich-markdown-editor@11.6.4
npm WARN   node_modules/rich-markdown-editor

I'm running NextJs v10.1.3. Although I've seen an issue about SSR with nextjs, this functionality shouldn't be connected with SSR anyways.

And here is the repro: https://github.com/MonstraG/RichMdEditorRepro

There is nothing to it really, it's just editor in a page. I've added console.log() in onChange and you can see that firefox doesn't trigger onChange and Chrome does.

tommoor commented 3 years ago

Unfortunately I'm just unable to reproduce on Firefox on Mac, it may be a Windows thing – but without being able to repro there can't be a fix.

tomershvueli commented 3 years ago

FWIW, I'm also seeing this issue on a Mac. Node 14.15.4.

MonstraG commented 3 years ago

I don't know if its related, but, in Chrome, when I hold LMB over checkbox, draggable="true" appears on <li>. image But in Firefox, not just draggable, but also contenteditable=false appears image