search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 588 forks source link

table row select toolbar options miss format #490

Closed JiangWeixian closed 2 years ago

JiangWeixian commented 3 years ago

A clear and concise description of what the bug is.

To Reproduce

  1. clone repo & yarn & yarn start
  2. go to story 'table'
  3. select row1 from col-Editor to col-React, toolbar will show format options, but select row1 from col-Editor to col-Collaborative, toolbar only show insert options

Expected behavior select full table row, toolbar should display format options + insert etc.. options

I found menu items in menus/tableRow not contain menuitems in menus/formatting, so not quite sure if it's a bug or a feature

https://github.com/outline/rich-markdown-editor/blob/9dd889932ebc688aaa1082108b24258e9b85aa1b/src/menus/tableRow.tsx#L6-L34

Version 11.13.0

Screenshots image

image

Desktop (please complete the following information):