search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 588 forks source link

perf: typo #493

Closed JiangWeixian closed 3 years ago

JiangWeixian commented 3 years ago
JiangWeixian commented 3 years ago

image

🙈 there is too much lint error, may i set 

"singleQuote": false

in eslintrc.js

tommoor commented 3 years ago

eslint doesn't show these errors on my side, not sure what this would be... editor setting?

JiangWeixian commented 3 years ago

eslint doesn't show these errors on my side, not sure what this would be... editor setting?

🤔 it's weird, could you execute yarn lint locally, if there are any lint error like these?

image

tommoor commented 3 years ago

There aren't errors, I'll also note that the default in prettier is double quotes: https://prettier.io/docs/en/rationale.html#strings

JiangWeixian commented 3 years ago

There aren't errors, I'll also note that the default in prettier is double quotes: prettier.io/docs/en/rationale.html#strings

thx reply, i clone repo on another pc, not prettier error anymore 🎉.