outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 588 forks source link

Extra line beneath the image after uploading #537

Closed wcjx closed 3 years ago

wcjx commented 3 years ago

As can be seen, there is an extra line between the image and the new paragraph after uploading an image. image Typing in this line, block menu shows up in the right top corner of the image, which is weird. The text node in this line has the same parent paragraph node as the image. image Another effect is that it takes two backspaces to delete this image after uploading.

To Reproduce Just upload an image

Expected behavior Setting image node schema as group: "block" can remove this line. This is more intuitive. image

Version 11.17.3

Desktop (please complete the following information):

tommoor commented 3 years ago

Unfortunately changing images to block nodes breaks many other behaviors and expectations of how images layout. Hopefully this can be addressed with css