outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 590 forks source link

Menu icon is not hidden after collapsing an heading in the editor #558

Closed Israel001 closed 2 years ago

Israel001 commented 2 years ago

After collapsing an heading in the editor, the text space under this heading is hidden but the menu icon next to the text space is still there.

To Reproduce Steps to reproduce the behavior:

  1. Insert any heading
  2. Press Enter
  3. Collapse the heading
  4. See error

Expected behavior I think the menu icon should not be there after the heading has been collapsed.

Version "rich-markdown-editor": "^11.17.5"

Screenshots

Seeds+2021-10-01+10-50-36

Desktop (please complete the following information):

Israel001 commented 2 years ago

@tommoor Hi there, thank you for fixing this bug pretty quick.

I just installed and tested the latest version of the library now. Unfortunately, the issue is still there but with a different reproduction scenario. This time around, the issue happens after deleting a new line that was created from a folded heading.

Here is how to reproduce:

  1. Insert any heading
  2. Collapse the heading
  3. Press Enter
  4. Press Backspace
  5. See error

Thanks in advance (: