search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.88k stars 590 forks source link

Switch to lodash-es #559

Closed gzuidhof closed 3 years ago

gzuidhof commented 3 years ago

Hi Tom,

Another small PR, this one to propose a switch to the ES Module based lodash distribution lodash-es.

My webpack (maybe yours too) struggles to treeshake the lodash functions, and it ends up including all 94KB of them. With this tiny change it should be able to do a better job and hopefully save every visitor 90KB.

tommoor commented 3 years ago

Hi @gzuidhof, given that we just had quite a nightmare with the es version of gemoji and the lack of widespread support (having to revert it and pin to an older non-es version) we won't be able to merge this PR.

The tooling for es modules just isn't there yet and we'd immediately get folks complaining.