search

outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 590 forks source link

Clicking on webpage outside the editor does not dismiss style popup #567

Closed bjj closed 3 years ago

bjj commented 3 years ago

Whenever a styling/editor popup appears, it can be cancelled by clicking away from the popup. But it only works if the click falls inside the active editor area, which can make it feel like the popup won't dismiss

To Reproduce Steps to reproduce the behavior:

  1. Edit a document
  2. Hilite some text and wait
  3. After the style popup appears, click away from it, but outside the editor div.

Expected behavior Popup dismisses

Version From the outline 0.59.0 docker image

Screenshots Here I have edited the style of the page to make the non-editor area red. Clicking on the red areas will not dismiss the popup:

image

Desktop (please complete the following information):