outline / rich-markdown-editor

The open source React and Prosemirror based markdown editor that powers Outline. Want to try it out? Create an account:
https://www.getoutline.com
BSD 3-Clause "New" or "Revised" License
2.87k stars 590 forks source link

Blinking cursor should always be on after cursor movement #570

Closed bjj closed 2 years ago

bjj commented 2 years ago

When moving up and down between blank lines in a code snippet, the cursor blinks normally. It should be forced on for each line change. The blinking makes it hard to determine

To Reproduce Steps to reproduce the behavior:

  1. Create a note
  2. Add a code snippet and insert some blank lines
  3. Cursor up and down between the lines and observe that the cursor is sometimes "off" when arriving on a line

Expected behavior Cursor should be forced on after each movement. That happens correctly when the cursor is on a non-blank line

Version Part of outline docker 0.59.0

Desktop (please complete the following information):

bjj commented 2 years ago

This also happens in another case: Create a line with a lot of spaces in it, and then hold down cursor left/right to move through it. The cursor blinks, so it appears to jump through the line instead of moving one character at a time.

tommoor commented 2 years ago

I suspect this is just an issue in Firefox, we don't do anything to manage the blinking of the cursor – that would be a browser level concern.

bjj commented 2 years ago

You are correct, I verified this does not happen on Chrome. I was thinking of CKEditor which does blink its own cursor.