more human-readable container names and kill cadvisor on 500

outlyerapp / dataloop-docker

Docker Autodiscovery Container

4 stars 4 forks source link

more human-readable container names and kill cadvisor on 500 #9

Closed safanaj closed 8 years ago

safanaj commented 8 years ago

Hi, this is a re-raise of #5

I cannot find an unstable brange to make the PR against, btw attached there is a patch against what I fetched some time ago as unstable branch.

all_in_one.diff.txt

sacreman commented 8 years ago

Hi, sorry for the confusion. Raising a pull request against the master branch is the correct thing to do. We had an unstable branch but kept accidentally deleting it when doing a pull request from that into master :)

We'll get this merged after testing. The only bit we were unsure about was the kill CAdvisor on 500. I've not seen that crash in a container yet. We're not adverse to the idea of killing and restarting it but just wondered under what conditions you found it to crash.