search

outmoded / hapi-contrib

Discussion forum for project contributors
Other
78 stars 25 forks source link

Plans for Node v6? #80

Closed cjihrig closed 5 years ago

cjihrig commented 8 years ago

Node 6 is scheduled to be released this month. Since it is the next LTS release, I assume it will be supported. What versions of Node will be supported once 6 comes out? Is there going to be another round of breaking releases to pick up new ES6 features?

Marsup commented 8 years ago

I'd say the way we switched to v4 was a clean cut, we'll get complains anyway but I don't see a better process.

vdeturckheim commented 8 years ago

Will there be any new major features in addition to the ones from v8 4.9 ?

nlf commented 8 years ago

v4 LTS is supported until 4/18. IMO we should support it until then.

Marsup commented 8 years ago

@nlf are you saying you want us to only use v4 features until then or break from it but backport security fixes only ?

nlf commented 8 years ago

i'd be fine with backporting security fixes to a version of hapi supporting node 4, but i also don't feel like a breaking change to depend on node 6 just for the sake of supporting node 6 has any merit.

until we reach the point that 6 has a feature we need/want to leverage we should carry on supporting 4. when that happens, we bump the major version of hapi and continue backporting security fixes to the previous major.

devinivy commented 8 years ago

This makes a lot of sense to me. The change from v0.10 to v4 was different for several of reasons. That said, I think at least all hapi core repos should act more or less in unison.

Marsup commented 8 years ago

Well I'd use destructuring, default parameters and spread for one. Also the change on Math.random() might have security implications, but I'm no crypto expert.

hueniverse commented 8 years ago

We are pretty much done with the node 0.10 LTS (v9.x) branch. With node v6 out, it will be the new baseline for hapi and node v4 the new LTS for hapi. Once hapi core uses features in node v6, we will follow the same process as we did with hapi v10 with a node-only breaking release. At that point we'll get all the deps to move up as well.

Note that once we move to node v6, we will no longer support node v5, only v4 as LTS.

The LTS support in hapi is pretty much exclusive for security updates and we never had that much of those.

Let's wait for v6 to come out, give it a few weeks, see how all our code is testing against it (travis is already set for v4 and latest).

gergoerdosi commented 8 years ago

Now that v6 is out, what are the next steps? I can dedicate some time to help with the move. What are the tasks?

hueniverse commented 8 years ago

First is getting lab to work on it. Then each hapi core module needs to test on it.

gergoerdosi commented 8 years ago

I think lab already works with v6: https://github.com/hapijs/lab/commit/c7dd9744c08c45d93231381d5964c76bfb181c85

Testing means updating lab and .travis.yml? In case of travis.yml, should 6 be explicitly specified, or is it enough to have latest?

geek commented 8 years ago

Lab already supports node v18.0.0

I will go through and test/open issues for other modules if I find any with the latest. I am using - 6 in travis.

hueniverse commented 8 years ago

Travis should be set to "4" and "6" only.