Closed rummanhasnayeen closed 5 years ago
I have deleted faketoe like the others. Please review changes.
On Thu, Jul 25, 2019 at 6:20 PM Jonas Pauthier notifications@github.com wrote:
@Nargonath requested changes on this pull request.
In lib/plugins.js https://github.com/hapijs/hapijs.com/pull/727#discussion_r307265914:
@@ -830,7 +822,7 @@ exports.categories = { description: 'A configuration document format, an API, and a foundation for A/B testing' }, faketoe: {
- url: 'https://github.com/hapijs/faketoe',
- url: 'https://github.com/drummel/faketoe',
Not sure that's a good idea to add a link to that repo. faketoe package on npm is still owned by Eran etc. : https://www.npmjs.com/package/faketoe. Plus the person who forked the repo didn't add a link to another package and doesn't seem either to maintain it so I would just go and delete it from the list like the rest you deleted.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/hapijs/hapijs.com/pull/727?email_source=notifications&email_token=AEYSXTVQCDTMQYYHC7KTRILQBGLBPA5CNFSM4IGZ65TKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB7R4T4Q#pullrequestreview-266586610, or mute the thread https://github.com/notifications/unsubscribe-auth/AEYSXTTMEHDBZQJJNVU5X23QBGLBPANCNFSM4IGZ65TA .
Fixed link:
Not available links: