Fixes two issues #161 and #162

outmoded / lout

API documentation generator

Other

276 stars 49 forks source link

Closed danactive closed 7 years ago

danactive commented 7 years ago

Fix hyperlink to hapi guidelines for contributing (#161)
Blankie support whitelists CDN fonts, styles, and scripts (#162)
Tested on Windows (no additional tests fail)
Optionally compatible with blankie closes blankie issue (https://github.com/nlf/blankie/issues/15)
- Works with or without blankie

danactive commented 7 years ago

Anyone able to help with this test failure? It's not clear what the string test is expecting.

Marsup commented 7 years ago

I'll have a look at the test failure, it's unrelated to this PR. I'd prefer an extension point rather than a hard-coded blankie config in there.

danactive commented 7 years ago

@Marsup Are you referring to an extension point such as onPreStart? I'm not able to change or define the route information on that server event.

Marsup commented 7 years ago

I mean be able to provide those options as part of the initialization of the plugin, this way it would support more than this specific use case.

Marsup commented 7 years ago

Do you still want to push this ?

danactive commented 7 years ago

Nah, it doesn't fit the project expectations