Closed hueniverse closed 6 years ago
@kreig303 are you still planning to work on this?
I started adding changes but I am confused with multi-connections. Help to figure out with that. https://github.com/venikman/lout
@venikman there are no multi-connections anymore. Each hapi server instance can only bind to one port. For multiple connections one has to instantiate multiple server instances.
Feel free to try my PR already #177
Everything should fully work but it still lacks test coverage so it needs some more work before merge ✌️
@henrikdahl I installed your PR locally and was able to run it successfully, with relatively minor changes to the example code. As far as the tests, is there anyway I can assist you on this?
Working fine for me.
@Pokom Sweet. Sure, most if it needs updating to Hapi 17 but also some of it is redundant (legacy Hapi support) now that the requirement is Hapi 17 and up, so it needs to be removed. I'm not fully aware which parts are there to support older versions ✌️
Edit: I pushed a commit that updates the first test block to work with Hapi 17, so you can get an idea of what needs to be updated.
@henrikdahl To be sure: you're referring to https://github.com/hapijs/lout/pull/177/commits/7b0b78ac26e4a57b69f588efeaf5bbf06fda6051 correct? If so, I can certainly try to update the test suite. If I need some assistance, what's your preferred way of getting in touch?
@Pokom It's actually wrong, it needs to be async/await. What about HapiJS Slack channel? ✌️
@henrikdahl I may need an invite, but I promise to be nice 😄
Forked this repo to take a stab at this... will have some time over the Thanksgiving holiday.
No promises. :)