outmoded / lout

API documentation generator
Other
276 stars 49 forks source link

hapi v17 support #175

Closed hueniverse closed 6 years ago

kreig303 commented 6 years ago

Forked this repo to take a stab at this... will have some time over the Thanksgiving holiday.

No promises. :)

sholladay commented 6 years ago

@kreig303 are you still planning to work on this?

venikman commented 6 years ago

I started adding changes but I am confused with multi-connections. Help to figure out with that. https://github.com/venikman/lout

ferrao commented 6 years ago

@venikman there are no multi-connections anymore. Each hapi server instance can only bind to one port. For multiple connections one has to instantiate multiple server instances.

henrikruscon commented 6 years ago

Feel free to try my PR already #177

Everything should fully work but it still lacks test coverage so it needs some more work before merge ✌️

Pokom commented 6 years ago

@henrikdahl I installed your PR locally and was able to run it successfully, with relatively minor changes to the example code. As far as the tests, is there anyway I can assist you on this?

ferrao commented 6 years ago

Working fine for me.

henrikruscon commented 6 years ago

@Pokom Sweet. Sure, most if it needs updating to Hapi 17 but also some of it is redundant (legacy Hapi support) now that the requirement is Hapi 17 and up, so it needs to be removed. I'm not fully aware which parts are there to support older versions ✌️

Edit: I pushed a commit that updates the first test block to work with Hapi 17, so you can get an idea of what needs to be updated.

Pokom commented 6 years ago

@henrikdahl To be sure: you're referring to https://github.com/hapijs/lout/pull/177/commits/7b0b78ac26e4a57b69f588efeaf5bbf06fda6051 correct? If so, I can certainly try to update the test suite. If I need some assistance, what's your preferred way of getting in touch?

henrikruscon commented 6 years ago

@Pokom It's actually wrong, it needs to be async/await. What about HapiJS Slack channel? ✌️

Pokom commented 6 years ago

@henrikdahl I may need an invite, but I promise to be nice 😄

henrikruscon commented 6 years ago

@Pokom https://join.slack.com/t/hapihour/shared_invite/enQtMjM5Njk1NDgzNTY5LThmODkxODIzOTg5NjJjODFiYjcxZDMxMTAyMzBkZDk3MWY4MTFlNDAyMTU3MmUwMmM0Y2UwMjU3YjAwYjRkN2E