search

outmoded / lout

API documentation generator
Other
276 stars 49 forks source link

joi as a dependency instead of peerDep? #97

Closed phated closed 9 years ago

phated commented 9 years ago

Just wondering why joi is a peerDep currently. It seems to better fit the dependency pattern.

Marsup commented 9 years ago

Good question, it seems for no reason, unless isRef changes between versions, which is unlikely.

Marsup commented 9 years ago

Oh now I remember, lout is not always backward compatible with older versions of joi, so it's mainly to enforce a baseline version.

phated commented 9 years ago

Makes sense. I had an error where lout tried to require joi and it wasn't available so the application crashed. Would it be possible to have joi as a dep and peerDep?

Marsup commented 9 years ago

Peer dependencies should install next to lout, npm should take care of that, if not maybe you had an error in the installation process.

phated commented 9 years ago

I'm working on some npm bugs right now, so that is probably it.