search

outmoded / tv

Interactive debug console
Other
186 stars 41 forks source link

Allow Secure Web Sockets #108

Closed Vatosteve closed 9 years ago

Vatosteve commented 9 years ago

Our hapi server is configured for https and we get the following error when attempting to view the debug console:

Uncaught SecurityError: Failed to construct 'WebSocket': An insecure WebSocket connection may not be initiated from a page loaded over HTTPS.

Are there any plans to support secure web sockets?

hueniverse commented 9 years ago

This module needs people to help maintain it. If you want this feature your best chances are to add it yourself...

rainabba commented 9 years ago

@hueniverse Any information you can provide to kick-start that effort? I'm having the same issue and am not unfamiliar with WS on Node/Hapi so I'd be willing to give it a shot, but better to not waste hours trying to find out where to start :)

hueniverse commented 9 years ago

I haven't looked at the code in a while...

hueniverse commented 9 years ago

@geek should we fine a new lead maintainer for this?

geek commented 9 years ago

@hueniverse how did you read my mind like that ;)

I have been asking around, but no one is interested who I have asked. Looks like I need to make that more public, I will file an issue.

rainabba commented 9 years ago

@geek Just curious, any ETA on this and are you looking for help still? I'm at a point where I'd really like to have this implemented.

If it's assumed to be for development only, then at a glance, it seems like this approach could work: https://github.com/dypsilon/hapi-ws-proxy-example/blob/master/proxy.js

https://github.com/nodejitsu/node-http-proxy#using-https

rainabba commented 9 years ago

Looks like implementing SSL is just a matter of getting the right connection object through (with keys) and the change was simple, but I'm getting 404's on /debug/console so I can't confirm. I'm not seeing any other issues so I'm guessing that I'm just being dense.

geek commented 9 years ago

@rainabba I added a PR for the feature... its open at the moment

rainabba commented 9 years ago

@geek Thanks. Any update on this?