Check for Inert and Vision as dependencies

[osukaa]

I'm still debating about how to handle hapi < 9

[devinivy]

Could hapi < 9 users just use the old version of tv? Maybe for the time being 4.x and (presumed to-be) 5.x series of tv could both be maintained with the same patch fixes, until hapi 8 is no longer supported by the hapi team.

[osukaa]

I think that would be an appropriate solution!

[osukaa]

In v8 they're registered in the core and beginning v9 it would ask the user to add them since it's in the server.dependency

[arb]

Might be worth taking a pass through "package.json" and making sure the dependency versions are cleaned up. I believe the standard is #.x.x for hapijs packages and #.#.x for non-hapijs package.

[osukaa]

@arb I cleaned the package.json

[arb]

Looks good. You should probably have one more person check it thought just to be safe.

[osukaa]

Maybe @geek can help us out. :) 

— Sent from Mailbox

On Wed, Aug 19, 2015 at 4:07 PM, Adam Bretz notifications@github.com wrote:

Looks good. You should probably have one more person check it thought just to be safe.

Reply to this email directly or view it on GitHub: https://github.com/hapijs/tv/pull/117#issuecomment-132802392

[Marsup]

Hello, just curious, why did you set the minor versions on most of your dependencies ?

[osukaa]

@Marsup I thought about the standard that @arb mentioned up there.

[Marsup]

Oh thanks, I didn't see it. @arb where's that mentioned ?

[arb]

Do conversations with Eran count :-) You're right though, I don't THINK that it's documented anywhere. I think the rules are:

• .x.x for hapijs packages

• .#.x for non-hapijs packages with version >=1.0.0

• .#.# for non-hapijs packages with version < 1.0.0 (if you use them at all)

At least that's what I've been going with.

[lloydbenson]

Maybe a good opportunity to add it in the contrib repo?