search

outmoded / tv

Interactive debug console
Other
186 stars 41 forks source link

get tv working with v4 of node and newer hapi #121

Closed lloydbenson closed 9 years ago

lloydbenson commented 9 years ago

@osukaa any issues with this PR?

osukaa commented 9 years ago

I'm not able to check it since I'm on another country on vacation :/ I'll be back next Monday 

— Sent from Mailbox

On Mon, Sep 21, 2015 at 4:08 PM, Lloyd Benson notifications@github.com wrote:

@osukaa any issues with this PR?

Reply to this email directly or view it on GitHub: https://github.com/hapijs/tv/pull/121#issuecomment-142080294

lloydbenson commented 9 years ago

Thanks for the update!

osukaa commented 9 years ago

Everything seems good to me!

lloydbenson commented 9 years ago

Great! Any plans to merge it?

osukaa commented 9 years ago

Yeah, I'm just not sure about versioning.

lloydbenson commented 9 years ago

I think a minor version would be appropriate as there aren't any breaking changes, just library updates to make this happen. As shown by travis this works for both 0.10 and the v4. I can update this but usually its left up to the maintainer to make this call.

osukaa commented 9 years ago

It's merged and published, it closes #119