outmoded / tv

Interactive debug console
Other
186 stars 41 forks source link

Set address for Hapi connection #125

Closed Bondza closed 8 years ago

Bondza commented 8 years ago

Allow setting the address connection option for tv, listed in the connectionoptions. This is required if you would like to run tv inside a Docker container without allowing it to use the host network.

osukaa commented 8 years ago

Hi,

Please create a test for this :)

Bondza commented 8 years ago

Sure, I've added another test to make sure it is possible to set the address option :)

rizowski commented 8 years ago

@Bondza This is something I am needing but I am unable to get diagnostics in a docker container even with these changes. What are you setting address to to get this to work?

Bondza commented 8 years ago

@rizowski I configured tv like this:

    {
        register: require('tv'),
        options: {
            address: '0.0.0.0',
            host: 'docker',
            port: 45000
        }
    },

I'm running docker on OS X, so I added docker as a hostname to /etc/hosts with the ip to the vm. If docker is not running inside a vm then localhost should work.