search

outmoded / tv

Interactive debug console
Other
186 stars 41 forks source link

Moved assignment of .tv property to first received event #92 #94

Closed heymichaelp closed 9 years ago

heymichaelp commented 9 years ago

This moves the assignment of request.plugins.tv to the request-internals hook and only executes when tags.received = true, which represents the first log in the request/response stack.

For what it's worth, I tried hooking this into the server.on('request') event, but it seems to not fire during a normal request.

heymichaelp commented 9 years ago

The tests will fail because of insufficient coverage. The #91 PR represents full coverage, so I will merge it in once it's resolved.

heymichaelp commented 9 years ago

@hueniverse this has passing tests and is ready for review.