search

outofcopyright / outofcopyright-website

Website components for OutOfCopyright.eu
http://outofcopyright.eu
Other
0 stars 2 forks source link

You can create orphaned graphs #26

Closed mzeinstra closed 9 years ago

mzeinstra commented 9 years ago

Steps to reproduce:

  1. start with this screen shot 2014-12-03 at 16 31 31
  2. Go to the parent to the primary node
  3. Go to Alias
  4. Select a result that already has more nodes underneath it. (Yes, in our example)
  5. Connect that result to a Result node.

screen shot 2014-12-03 at 16 35 05

See the offspring of Frankenstein! :)

mzeinstra commented 9 years ago

BTW, this graph did not want to save, but gave an OK save message back

jeromejesse commented 9 years ago

Ok I understand the problem. We have several solutions. The first is not possible to make an alias leading to a lonely node. The second would be to allow this, but that non hung up the tree branch would be eliminated. And the last would be allowed like that to let the choice to the user of this lonely branch hung up again to the tree.

mzeinstra commented 9 years ago

I would think this is the best solution:

  1. Allow these kinds of nodes to be made
  2. If this makes orphan nodes have a message say that all nodes underneath that question will be deleted with an accept and cancel button.

Note that it is possible to create Alias nodes high in a existing tree without making orphan nodes, so we have to check for that.

Is that possible?

jeromejesse commented 9 years ago

Yes it's possible. In the case where the node does not have a unique connection to a parent node in this case there will be no orphan node.