outrauk / dataiku-plugin-snowflake-hdfs

DSS plugin for fast loading between Snowflake and HDFS
https://github.com/outrauk/dataiku-plugin-snowflake-hdfs
MIT License
0 stars 0 forks source link

Ready for a first round of review #1

Closed mklaber closed 5 years ago

mklaber commented 5 years ago

Still need to write some tests and add a bit more documentation.

mklaber commented 5 years ago

I may make class changes in a future iteration but I tend to avoid that when there is no shared state between methods. That is to say, any class level properties/fields are set in the constructor and are effectively "final" throughout. Blah blah blah OOP design feelings.

Should be ready for your re-review.