outroll / vesta

VESTA Control Panel
http://vestacp.com
GNU General Public License v3.0
2.97k stars 1.03k forks source link

Allow MySQL user length upto 32 characters #1621

Open ram108 opened 6 years ago

ram108 commented 6 years ago

The maximum length for a user name in MySQL does depend on the version, as stated in the manual: http://dev.mysql.com/doc/refman/5.7/en/user-names.html

MySQL user names can be up to 32 characters long (16 characters before MySQL 5.7.8).

Please consider to extend user length limit in VestaCP from 16 to 32 characters.

Request reference: https://github.com/serghey-rodin/vesta/issues/1023. Manual fix in russian: vesta forum.

dpeca commented 6 years ago

I will take a care of it soon.

mehargags commented 6 years ago

Yes... this is much needed revision as all major Distributions (CentOS 7, Debian 9, Ubuntu 16.07) use MariaDB by default which supports even upto 80 chars. and now even official MySQL 5.7 supports upto 32.

I think making it upto 30 would be a safe bet.

onfire-d commented 6 years ago

Would also be great to make MariaDB 10.2 by default.. can't believe it is still MariaDB 5

ram108 commented 6 years ago

Package installation depends by OS not Vesta.

Luc45 commented 5 years ago

Just bumping this to say that I would like this too. Thanks.

lukapaunovic commented 5 years ago

@dpeca BUMP

PecceG2 commented 5 years ago

Death? :-1:

tlcd96 commented 5 years ago

dunno

lukapaunovic commented 5 years ago

It's a simple fix.. if MySQL version >=56 allow 32... or if it's mariadb greater than >=5.5.31 too

As of MariaDB 5.5.31, it allows a user name length up to 80 characters long; see https://mariadb.atlassian.net/browse/MDEV-4332 and https://mariadb.com/kb/en/create-user/#user-names

I would write a fix but they won't accept my pull request because "they do not have time to test it". So I have given up making any future changes to this repo.

tlcd96 commented 5 years ago

@lukapaunovic i believe so, but neither i have lately time to commit here... also we have that problem that you referred.

mtacore commented 5 years ago

Honestly, you should give HestiaCP a try (VestaCP fork). It uses MariaDB 10.3 by default and has the length increased (among other fixes and enhancements). Just look for it at GitHub.

anton-reutov commented 5 years ago

MySQL User 32 version from 5.7.8 MariaDB User 32 version from 5.5.31