outscale / cluster-api-provider-outscale

BSD 3-Clause "New" or "Revised" License
4 stars 10 forks source link

feat(securityGroups): Improve robustness of security group reconcilers #373

Open gvdhart opened 1 month ago

gvdhart commented 1 month ago

Rework of the security group reconcilers so that they are more robust and stable.

Add option in security group spec to remove default outbound rule that allows all outbound traffic

fixes #344 fixes #326 fixes #322

gvdhart commented 1 month ago

Tested with a large cluster (10+ sg's and 30+ sg rules) and it works well, reconciliation time of sg is greatly improved and more robust. Adding security groups after the OscCluster has been reconciled works. Adding security group rules after the OscCluster has been reconciled works. Deleting the OscCluster will correctly delete all sg rules and sg's. Deleting a single sg after the OscCluster has been reconciled works.

TODO:

outscale-hmi commented 4 weeks ago

Hello,

I reviewed this PR and I’m okay with the overall logic. However, some unit tests are failing because of missing calls in certain test cases, additionally, there's a segmentation fault occurring, which likely needs addressing. Could you please update the unit tests to include these missing calls to ensure full coverage of the new logic?