outscale / osc-bsu-csi-driver

Apache License 2.0
8 stars 18 forks source link

Fill SnapshotId in Disk structure - v0.X #798

Closed outscale-mdr closed 9 months ago

outscale-mdr commented 9 months ago

Is this a bug fix or adding new feature? This PR is to fix a bug o idempotency in CreateVolume call. Indeed, if another call is submited with the same parameter with snapshotId, the second call with failed with an error.

E0117 17:39:32.587993       1 driver.go:112] GRPC error: rpc error: code = AlreadyExists desc = Volume already exists, but was restored from a different snapshot than snap-XXXX

What is this PR about? / Why do we need it? All calls must be idempotent therefore this is necessary in order not to be stuck

What testing is done? Test of the cloud Call have been added to detect any future regression on this.