search

outscale / osc-cost

Analysis of cloud costs for 3DS Outscale
5 stars 3 forks source link

Improve helm and allow some parameters in command line #100

Closed albundy83 closed 1 year ago

albundy83 commented 1 year ago

Add some improvements using helm chart. Allow to pass parameters to command (especially --skip-resource Oos)

ghost commented 1 year ago

Thanks for your contribution @albundy83. Can you update the version of helm charts with your change ?

https://github.com/outscale/osc-cost/blob/main/helm/osccost/Chart.yaml#LL18C3-L18C3

Ok for the rest of the PR

albundy83 commented 1 year ago

Hello, sure which version do you want ? 0.2.2 or 0.3.0 ?

albundy83 commented 1 year ago

And also, as Dockerfile is updated, docker image on docker.io will be automatically updated ? Should I change also imageTag value ?

ghost commented 1 year ago

version: 0.3.0 appVersion: "0.3.1"

ghost commented 1 year ago

Please also change imageTag https://github.com/outscale/osc-cost/blob/e8554edf64d54dc6fc8e20752b8143abb7663e3d/helm/osccost/values.yaml#L43

A new release 0.3.1 will integrate your change.

https://github.com/outscale/osc-cost/blob/main/.github/workflows/release-docker-image.yml

albundy83 commented 1 year ago

Ok done, sorry for delay

ghost commented 1 year ago

Closes #101

albundy83 commented 1 year ago

I had to change also the livenessProbe and readinessProbe as they never work

ghost commented 1 year ago

Ok

ghost commented 1 year ago

@albundy83 it will be available with the new version 0.3.1 which will be available very soon.