Given Match ID and Player ID return statistics of Player in that match

outside-edge / python-espncricinfo

Python wrapper for the ESPNCricInfo JSON API

MIT License

145 stars 64 forks source link

Given Match ID and Player ID return statistics of Player in that match #13

Closed sbshah97 closed 6 years ago

sbshah97 commented 6 years ago

Given a particular Match ID in the Player class, it should return the batting and bowling statistics for that player in that match.
If the player hasn't played that match, it should return a different values rather than default 0/0 - bowling and 0(0) - batting

To Decide:

How should the format of the output be like?
Any clues as to how to start this?

dwillis commented 6 years ago

@salman-bhai I'd love to do this. I think we can using the match JSON (example). We should first decide on the output. I agree that if a player hasn't played in a match the output should indicate that somehow, maybe with boolean values for batted and bowled. What else should we have?

dwillis commented 6 years ago

@salman-bhai I've taken a run at this with 42238c98b186fa3e18e2e7f006f5dc53c0a8d774. Check it out - the Player class now has batting_for_match and bowling_for_match methods where you supply a match ID.

sbshah97 commented 6 years ago

I think this looks amazing as of now