search

outside-edge / python-espncricinfo

Python wrapper for the ESPNCricInfo JSON API
MIT License
146 stars 64 forks source link

Espn website used for JSON object not available #38

Closed pranaykarwa closed 3 years ago

pranaykarwa commented 4 years ago

Hi! Amazing work with this project. Although I haven't quite understood how to use it entirely, I tried to read through the code, and found this in 'player.py'

self.json_url = "https://core.espnuk.org/v2/sports/cricket/athletes/{0}".format(str(player_id))

This URL isn't available anymore it seems. Would you happen to know any alternate websites or sources where we could get player data packaged in a JSON?

dwillis commented 4 years ago

@pranaykarwa Thanks! Sadly I have not found an alternative and will be removing json_url from the Player objects.

prasanna-sk commented 3 years ago

Hi! Amazing work with this project. Although I haven't quite understood how to use it entirely, I tried to read through the code, and found this in 'player.py'

self.json_url = "https://core.espnuk.org/v2/sports/cricket/athletes/{0}".format(str(player_id))

This URL isn't available anymore it seems. Would you happen to know any alternate websites or sources where we could get player data packaged in a JSON?

Just change the https to http. It looks like https has been removed for quite a few of the links. e.g. below works http://core.espnuk.org/v2/sports/cricket/athletes/447261

Have raised an issue for similar for another link - https://github.com/dwillis/python-espncricinfo/issues/43

dwillis commented 3 years ago

@prasanna-sk @pranaykarwa thank you - have pushed this change.