outside-edge / python-espncricinfo

Python wrapper for the ESPNCricInfo JSON API
MIT License
144 stars 65 forks source link

Fixed error caused by cricinfo website update #45

Closed BoredCyborg closed 3 years ago

BoredCyborg commented 3 years ago

The cricinfo website updated causing the summary module to be unable to fetch the match ids. The module is now able to successfully fetch the match ids, however the _build_matches() function may raise a NoScorecardError.

I was originally getting this error: Traceback (most recent call last): File "", line 1, in File "C:\Users####\AppData\Local\Programs\Python\Python38-32\lib\site-packages\espncricinfo\summary.py", line 12, in init self.match_ids = self._match_ids() File "C:\Users####\AppData\Local\Programs\Python\Python38-32\lib\site-packages\espncricinfo\summary.py", line 30, in _match_ids matches = [x['id'] for x in self.summary_json()['props']['pageProps']['data']['content']['leagueEvents'][0]['matchEvents']] TypeError: 'NoneType' object is not subscriptable

EDIT: The Summary() issue is now fixed with the new commit. The Match() issue still needs to be fixed