ouyang789987 / swfobject

Automatically exported from code.google.com/p/swfobject
0 stars 0 forks source link

embedSWF shouldn't require an id string #361

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. embedSWF("file.swf", divElement, ... );
2.
3.

What is the expected output? What do you see instead?
It should allow both a string and an object. If I remember correctly, swfobject 
versions prior to 
2.0 supported this.

What version of the product are you using? On what operating system?
2.2, Mac OS X 10.5.8

Please provide any additional information below.
My alternate content container does not have an id, but a class instead. I can 
work around this 
issue by applying an id to the div in script, then continuing to use embedSWF 
as its documented. 
However, there's something crappy about doing it that way.

Original issue reported on code.google.com by prom...@gmail.com on 17 Aug 2009 at 1:42

GoogleCodeExporter commented 9 years ago
This is neither a feature nor a bug.

Original comment by bobbyvandersluis on 18 Aug 2009 at 1:26

GoogleCodeExporter commented 9 years ago
Requesting the addition of the support for a div element to be used in the "id" 
argument is neither a feature nor 
a bug?

Prior versions of swfobject had this ability, so this could be classified as a 
BUG, or merely a forgotten feature. In 
which case, I am requesting the FEATURE.

If you hate the idea, fine. But it's not what you say it is.

Original comment by prom...@gmail.com on 18 Aug 2009 at 1:52

GoogleCodeExporter commented 9 years ago
If you log it as a defect instead of an enhancement, that's how it gets 
interpreted.

As a feature request, we have had the request before and it was on the feature 
list
in early alpha versions of SWFObject 2, however we decided not to support 
classes as
hooks, because it costs us relatively to many KBs for functionality that's only 
used
by a few people. So it's not that we don't like the idea of using classes or 
even
HTML nodes, we do like it, however we chose not to implement them to keep the 
core
library small.

About older versions of SWFObject, I am not sure if it supported classes as 
hooks, I
can't see it being documented - http://blog.deconcept.com/swfobject/

In any case, SWFObject 2 is the successor of SWFObject 1.x, UFO and the Adobe 
Flash
Detection Kit, so that's why it's not automatically backwards compatible with
SWFObject 1.x, nor will it guarantee that it will include all previous features.

You can use the SWFObject 2 API to create your own additional code to use 
classes as
hooks though. 

Original comment by bobbyvandersluis on 19 Aug 2009 at 7:35

GoogleCodeExporter commented 9 years ago
There was no "enhancement" option.

And, I wasn't really requesting the support of classes as hooks, but just HTML 
nodes. I haven't analyzed the 
source code all that much, but I can't imagine it adding more than a few 
conditions.

Either way, it's your project and you know what's best for it. Thanks for 
reading.

Original comment by prom...@gmail.com on 19 Aug 2009 at 1:47

GoogleCodeExporter commented 9 years ago
RE: There was no "enhancement" option.

You're right, my bad :-)

Original comment by bobbyvandersluis on 20 Aug 2009 at 2:01

GoogleCodeExporter commented 9 years ago
:)

Original comment by prom...@gmail.com on 20 Aug 2009 at 3:02