search

ovalhub / pyicu

The PyICU project repository has moved to https://pyicu.org.
Other
133 stars 50 forks source link

resolve compiler error in visual c++. #109

Closed kochelmonster closed 5 years ago

kochelmonster commented 5 years ago

This pull request contains the changes discussed in #98. Also if it is perfect standard c++, the fact is: msvc does not compile it, and I don't assume Microsoft will change their compiler.

For those who are interested: I was able to compile pyicu with the following conda packages:

tavianator commented 4 years ago

For the record it is not standard C++ to include preprocessing directives inside of macro calls: https://stackoverflow.com/a/28343676/502399

ovalhub commented 4 years ago

Bummer but thanks for clarifying.

On Oct 3, 2019, at 08:15, Tavian Barnes notifications@github.com wrote:

For the record it is not standard C++ to include preprocessing directives inside of macro calls: https://stackoverflow.com/a/28343676/502399

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.