search

ovasquez / mkdocs-merge

Merge the source of multiple MkDocs sites into a single one
https://ovasquez.github.io/mkdocs-merge/
MIT License
24 stars 6 forks source link

Add support for section index pages #18

Closed Acerinth closed 1 year ago

Acerinth commented 1 year ago

Closes #17

ovasquez commented 1 year ago

Hi @Acerinth, thanks for the interest in this tool and for adding support for this feature! 💯 Do you know how this new item would look like in a test like the ones written in this file? https://github.com/ovasquez/mkdocs-merge/blob/main/mkdocsmerge/tests/merge_test.py I ask because I want to make sure this feature doesn't break in the future, so ideally we would have a test to make sure it keeps working as expected in future releases.

Acerinth commented 1 year ago

Hey @ovasquez , thanks for such a quick response!

Yes, definitely. I've already thought about it, but I wanted to check with you before implementation. Should I just adjust the mocks in all three existing tests, or do you want me to create a completely new test? As this is not a new function, but just a change to the existing one, to me the first option makes more sense. What do you think?

ovasquez commented 1 year ago

@Acerinth I think a separate test would be better, because it can be focused on this feature, and in case it breaks, it would be easier to identify which feature broke. Does this make sense?

Acerinth commented 1 year ago

@ovasquez Sure, no problem. I've added a separate test now and double checked that it fails if my new 4 lines are not there ;) Is there anything else I should add/change? Did I miss anything?

ovasquez commented 1 year ago

Looks great to me. Thanks @Acerinth for adding the feature and the test! Version 0.8.0 with your changes has been published.