oveits / ProvisioningEngine

Ruby on Rails based ProvisioningEngine Frontend for provisioning of legacy systems via Apache Camel Backend (SOAP/XML+SPML+File import)
3 stars 6 forks source link

Provisioning Task for Synchronization shows retry button, although "Retry" is not yet implemented #31

Closed oveits closed 8 years ago

oveits commented 8 years ago

If the "Retry" button is pressed, a Delayed::Job is created, but it will fail, since the method 'deliver' supports actions like "Add/Delete Customer/Site/User" only. "Synchonize Customer" is not yet supported, and it is not clear yet, whether I want to keep this naming conventions for GeneralJobs at all.

Note: Synchronize is the first method that makes use of the new GeneralJob model based on ActiveJobs. In GeneralJob, I have used Provisionings (=provisioning Tasks) only to record the GeneralJob in the database. I did not intend to use the 'provisioning_task.deliver' method and the manipulation of the object, since I think this should be moved to GeneralJob code instead...

For now, I should remove the "Retry button" either for all jobs/tasks or only for Synchronize jobs.

Prio is high, since a non-functional button is shown to the user.

oveits commented 8 years ago

For now, I have only removed the retry button for synchronize jobs:

# app/views/provisionings/index.html.erb
...
<% if !/synchronize/.match(provisioning.action) %>
                        <%= link_to 'Retry', deliver_provisioning_path(provisioning), method: :put, class: "btn btn-default", data: { confirm: 'Are you sure?'} %>
<% end %>

-> resolved (but not yet committed)