`console.table` bugfix - Githubissues

oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one

https://bun.sh

Other

71.08k stars 2.47k forks source link

`console.table` bugfix #10876

Closed dylan-conway closed 1 week ago

dylan-conway commented 1 week ago

What does this PR do?

ref strings coming from property iterator. deref is called on them after printing the table. The original issue would fail after about 5 iterations because the name strings would deref to 0.

fixes #10791

How did you verify your code works?

added a test

github-actions[bot] commented 1 week ago

❌ @dylan-conway, your commit has failing tests :(

💪 2 failing tests Darwin AARCH64

test/js/bun/http/serve.test.ts 1 failing
test/js/node/http2/node-http2.test.js 1 failing

💻 2 failing tests Darwin x64 baseline

test/js/bun/http/serve.test.ts 1 failing
test/js/web/workers/worker.test.ts 1 failing

💻 3 failing tests Darwin x64

test/js/bun/http/serve.test.ts 1 failing
test/js/web/fetch/fetch.tls.test.ts 1 failing
test/js/web/workers/worker.test.ts 1 failing

🐧💪 1 failing tests Linux AARCH64

test/js/deno/crypto/webcrypto.test.ts 1 failing

🪟💻 12 failing tests Windows x64 baseline

test/bundler/large_asset_regression.test.ts 1 failing
test/cli/install/bunx.test.ts 1 failing
test/cli/install/registry/bun-install-registry.test.ts 4 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/dns/resolve-dns.test.ts 2 failing
test/js/bun/http/serve-body-leak.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/bun/shell/commands/rm.test.ts 1 failing
test/js/deno/performance/performance.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing

🪟💻 7 failing tests Windows x64

test/cli/install/bunx.test.ts 1 failing
test/cli/install/registry/bun-install-registry.test.ts 3 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing