Closed paperdave closed 1 week ago
β @paperdave, your commit has failing tests :(
test/js/bun/http/serve.test.ts
2 failingtest/js/node/http2/node-http2.test.js
1 failingtest/js/bun/http/serve.test.ts
1 failingtest/js/web/workers/worker.test.ts
1 failingtest/cli/install/bun-create.test.ts
2 failingtest/cli/install/registry/bun-install-registry.test.ts
2 failingtest/js/web/workers/worker.test.ts
1 failingtest/cli/install/bun-add.test.ts
2 failingtest/cli/install/bun-create.test.ts
1 failingtest/cli/install/bun-install.test.ts
7 failingtest/cli/install/bunx.test.ts
1 failingtest/cli/install/registry/bun-install-registry.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failingtest/js/node/watch/fs.watchFile.test.ts
STATUS_SEVERITY_ERRORtest/cli/install/bunx.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/shell/commands/rm.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failing
What does this PR do?
Fixes #10856 Fixes #10435 Fixes #10460 Fixes #10545 Fixes #10546 Fixes #10547 Fixes #10578 Fixes #10583 Fixes #10615 Fixes #10629 Fixes #10700 Fixes #10755 Fixes #10756 For #10788, this will resolve their third point. Fixes #10790 Fixes #10798 Fixes #10841 Fixes #10853
Besides 10788, all of the above are the same exact issue report.
What went wrong is when compiling dependencies is the logic in every dependency script is
This overrides the baseline state of the shell to haswell, which will unintentionally compile newer code for older cpus.
We also never even tried compiling tcc correctly. The proper flags are added.
When using SDE, I noticed a very odd failure reported in
WTF::initialize
, which names the current thread. This applies for any JS entrypoint, which is different from the mostly install-related ones above (makes sense, sincelibarchive
is a notable dependency, while the js runtime in general is mostly just JSC + our own code + simdutf). I dont think the change in JSC is significant but it is definetly on the safer side to do this.