Closed Jarred-Sumner closed 1 week ago
β @Jarred-Sumner, your commit has failing tests :(
test/js/bun/http/serve.test.ts
1 failingtest/js/node/http2/node-http2.test.js
1 failingtest/js/bun/http/serve.test.ts
1 failingtest/cli/install/registry/bun-install-registry.test.ts
2 failingtest/js/bun/http/serve.test.ts
1 failingtest/integration/mysql2/mysql2.test.ts
6 failingtest/cli/install/bunx.test.ts
1 failingtest/cli/install/registry/bun-install-registry.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failingtest/cli/install/bunx.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/deno/performance/performance.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failing
What does this PR do?
Let's avoid this footgun in the future
Add assertion that count() was called before allocate() in lockfile stringbuilder
How did you verify your code works?