Closed nektro closed 1 week ago
β @nektro, your commit has failing tests :(
test/cli/install/bun-install.test.ts
1 failingtest/integration/esbuild/esbuild.test.ts
1 failingtest/js/bun/http/serve.test.ts
2 failingtest/js/third_party/postgres/postgres.test.ts
4 failingtest/js/bun/http/serve.test.ts
1 failingtest/js/third_party/postgres/postgres.test.ts
4 failingtest/js/web/workers/worker.test.ts
1 failingtest/js/bun/http/serve.test.ts
1 failingtest/js/third_party/postgres/postgres.test.ts
4 failingtest/cli/install/bunx.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/shell/commands/rm.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failingtest/js/third_party/postgres/postgres.test.ts
SIGTERMtest/cli/install/bunx.test.ts
1 failingtest/integration/next-pages/test/dev-server-ssr-100.test.ts
1 failingtest/integration/next-pages/test/dev-server.test.ts
1 failingtest/integration/next-pages/test/next-build.test.ts
1 failingtest/js/bun/shell/bunshell.test.ts
1 failingtest/js/bun/spawn/spawn.test.ts
1 failingtest/js/node/dns/node-dns.test.js
2 failingtest/js/third_party/postgres/postgres.test.ts
SIGTERMtest/js/web/fetch/fetch.tls.test.ts
1 failingundici-fetch, in Node.js:
> fetch("https://www.toptal.com/developers/postbin/1715151383763-3950115528423", { body: "123", headers: { "Content-Length": "2048" }, method: "POST" })
Promise {
<pending>,
[Symbol(async_id_symbol)]: 148,
[Symbol(trigger_async_id_symbol)]: 121
}
> Uncaught [TypeError: fetch failed] {
[cause]: RequestContentLengthMismatchError: Request body length does not match content-length header
at AsyncWriter.end (node:internal/deps/undici/undici:8088:19)
at writeIterable (node:internal/deps/undici/undici:7992:16) {
code: 'UND_ERR_REQ_CONTENT_LENGTH_MISMATCH'
}
}
I don't think we should make this change in the HTTP client itself. I think if we want to allow users to override Content-Length via node:http, we should have some other mechanism for doing so which does not percolate up to the global fetch API
another case caught by running axios tests