Fix `BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD` env var - Githubissues

oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one

https://bun.sh

Other

71.29k stars 2.5k forks source link

Fix `BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD` env var #11078

Closed Jarred-Sumner closed 2 weeks ago

Jarred-Sumner commented 2 weeks ago

What does this PR do?

Fix BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD env var so that it handles more ways to say false. Any value which is not a falsy value makes it set to true, if it is set

For example:

BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD=123 bun --watch src/server.ts will disable clearing the screen
BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD=0 bun --watch src/server.ts will enable clearing the screen
BUN_CONFIG_NO_CLEAR_TERMINAL_ON_RELOAD= bun --watch src/server.ts will enable clearing the screen

Fixes https://github.com/oven-sh/bun/issues/10725

How did you verify your code works?

Did not test it.

github-actions[bot] commented 2 weeks ago

❌ @Jarred-Sumner, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

test/js/bun/http/serve.test.ts 2 failing

💻 2 failing tests Darwin x64 baseline

test/cli/install/registry/bun-install-registry.test.ts 2 failing
test/js/bun/http/serve.test.ts 1 failing

💻 2 failing tests Darwin x64

test/js/bun/http/serve.test.ts 1 failing
test/js/bun/test/test-test.test.ts 1 failing

🐧💪 1 failing tests Linux AARCH64

test/js/third_party/jsonwebtoken/noTimestamp.test.js 1 failing

🐧🖥 1 failing tests Linux x64 baseline

test/js/node/child_process/child_process-node.test.js 1 failing

🪟💻 7 failing tests Windows x64 baseline

test/cli/install/bunx.test.ts 4 failing
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/process/process.test.js 2 failing

🪟💻 9 failing tests Windows x64

test/cli/install/bunx.test.ts 1 failing
test/cli/install/migration/migrate.test.ts 1 failing
test/cli/install/registry/bun-install-registry.test.ts SIGTERM
test/integration/next-pages/test/dev-server-ssr-100.test.ts 1 failing
test/integration/next-pages/test/dev-server.test.ts 1 failing
test/integration/next-pages/test/next-build.test.ts 1 failing
test/js/bun/shell/bunshell.test.ts 1 failing
test/js/node/dns/node-dns.test.js 2 failing
test/js/node/process/process.test.js 2 failing

Jarred-Sumner commented 2 weeks ago

manually tested