oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
74.5k stars 2.79k forks source link

Bun crashes when migrating from package-lock with a git dependency #12205

Closed wundersolutions-juanjo closed 1 month ago

wundersolutions-juanjo commented 5 months ago

How can we reproduce the crash?

Tested with the following package.json, no other files on folder, running on a Powershell windows terminal

{
  "dependencies": {
    "sass": "^1.35.1",
    "@hasanm95/cogo-toast": "https://github.com/hasanm95/cogo-toast"
  }
}

Using NPM 10.2.4

Relevant log output

Bun v1.1.13 (bd6a6051) Windows x64 Args: "C:\Users\Juanjo.bun\bin\bun.exe" "i" Elapsed: 2033ms | User: 15ms | Sys: 93ms RSS: 97.37MB | Peak: 97.64MB | Commit: 0.15GB | Faults: 25605

Stack Trace (bun.report)

Bun v1.1.13 (bd6a605) on windows x86_64 [InstallCommand]

panic: Internal assertion failure

github-actions[bot] commented 5 months ago

@wundersolutions-juanjo, the latest version of Bun is v1.1.16, but this crash was reported on Bun v1.1.13.

Are you able to reproduce this crash on the latest version of Bun?

bun upgrade
wundersolutions-juanjo commented 5 months ago

Yup, still reproducible;

Bun v1.1.17 (bb66bba) on windows x86_64 [InstallCommand]

panic: Internal assertion failure

wundersolutions-juanjo commented 5 months ago

I should also mention that after that crash, running the command again works fine, and that i'm pretty sure it's also reproducible on mac M1

dylan-conway commented 1 month ago

Fixed in bun v1.1.31 with #14461