Rewrite `node:crypto` - Githubissues

Jarred-Sumner commented 2 months ago

There are several open issues about node:crypto

Our current implementation of node:crypto is an incrementally modified fork of the browserify crypto polyfill with a lot of BoringSSL bindings added in key places.

The browserify crypto polyfill was a great starting point, but we've outgrown it.

When you skim through the code, you'll note that very little of it makes sense in the context of Bun

https://github.com/oven-sh/bun/blob/1bec6c3810ad49272e0f7ad385c1dd3efbfd7d19/src/js/node/crypto.ts#L2238-L2258

It has a JavaScript implementation of MD5, SHA1, crypto.randomBytes, DES, AES, diffieHelman, etc. We have BoringSSL. We even expose BoringSSL's MD5, SHA1, etc. Let's use it.

Let's also get rid of the commonJS wrappers in it. The only JavaScript code in node:crypto should be related to streams, or wrapping a native implementation in a stream. Everything else should be in native code.

The other issue here is in the particular stream implementations themselves. There are likely many small subtly incompatible bugs in the various classes exposed by node:crypto. We need to be running node's tests against our crypto implementation. Ideally, we'd be running other test suites too for this.

wpaulino commented 2 months ago

I plan to start with the switch to BoringSSL for publicEncrypt/privateDecrypt.

jlucaso1 commented 1 month ago

I need help to complete the feature to implement X25519. I have copied files from safari webkit implementation, but with no success https://github.com/oven-sh/bun/pull/13798

oven-sh / bun

Rewrite `node:crypto` #13681