Closed vjpr closed 1 year ago
make identifier-cache
task is failing:/Users/Vaughan/.bun-tools/zig/zig run src/js_lexer/identifier_data.zig
thread 50504284 panic: Darwin is handled separately via std.zig.system.darwin module
Unable to dump stack trace: debug info stripped
make: *** [identifier-cache] Abort trap: 6
make bindings
failing too:/usr/local/opt/llvm@13/bin/clang++ -I/Users/Vaughan/dev/fork/+bun/bun/src/deps/uws/uSockets/src -I/Users/Vaughan/dev/fork/+bun/bun/src/deps/uws/src -I/Users/Vaughan/dev/fork/+bun/bun/src/deps -I/Users/Vaughan/dev/fork/+bun/bun/src/deps/mimalloc/include -Isrc/napi -I/Users/Vaughan/dev/fork/+bun/bun/src/deps/boringssl/include -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/WTF/Headers -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/ICU/Headers -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/bmalloc/Headers -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/ -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/include -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/JavaScriptCore/PrivateHeaders -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/bmalloc/PrivateHeaders -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release/WTF/PrivateHeaders -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/bindings/ -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/builtins -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/bindings -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/bindings/webcore -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/bindings/webcrypto -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/bindings/sqlite -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/builtins/cpp -I -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/modules -I/Users/Vaughan/webkit-build/include -I/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/Source -std=c++2a -DSTATICALLY_LINKED_WITH_JavaScriptCore=1 -DSTATICALLY_LINKED_WITH_WTF=1 -DSTATICALLY_LINKED_WITH_BMALLOC=1 -DBUILDING_WITH_CMAKE=1 -DBUN_SINGLE_THREADED_PER_VM_ENTRY_SCOPE=1 -DNDEBUG=1 -DNOMINMAX -DIS_BUILD -DBUILDING_JSCONLY__ -DASSERT_ENABLED=0 -fvisibility=hidden -fvisibility-inlines-hidden \
-mmacosx-version-min=11.0 \
-O1 -mtune=native \
-fno-exceptions \
-fno-rtti \
-ferror-limit=1000 \
\
-g3 -c -o src/bun.js/debug-bindings-obj/BunJSCModule.o src/bun.js/bindings/BunJSCModule.cpp
src/bun.js/bindings/BunJSCModule.cpp:73:19: error: no member named 'setInspectable' in 'JSC::JSGlobalObject'
globalObject->setInspectable(true);
~~~~~~~~~~~~ ^
1 error generated.
Was a Zig issue. The fork Bun uses for Zig doesn't work on macOS.
brew install zig
ZIG=/usr/local/Cellar/zig/0.10.0/bin/zig make identifier-cache
Issue created: https://github.com/oven-sh/bun/issues/1490
Command failing:
'/opt/homebrew/bin/ninja' '-C' '/Users/Vaughan/dev/fork/+bun/bun/src/bun.js/WebKit/WebKitBuild/Release' '-t' 'recompact'
Just re-ran it make jsc
...
make identifier-cache jsc dev
Probably due to wrong zig version...
ZIG=/usr/local/Cellar/zig/0.10.0/bin/zig make identifier-cache jsc dev
/usr/local/Cellar/zig/0.10.0/bin/zig build headers-obj
/Users/Vaughan/dev/fork/+bun/bun/src/resolver/resolve_path.zig:43:22: error: invalid builtin function: '@minimum'
min_length = @minimum(str.len, min_length);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/Vaughan/dev/fork/+bun/bun/src/resolver/resolve_path.zig:195:22: error: invalid builtin function: '@minimum'
const shortest = @minimum(normalized_from.len, normalized_to.len);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
/Users/Vaughan/dev/fork/+bun/bun/src/resolver/resolve_path.zig:1260:6: error: empty test name must be omitted
test "" {
^~
/Users/Vaughan/dev/fork/+bun/bun/build.zig:596:70: error: no field named 'iterate' in struct 'fs.Dir.OpenDirOptions'
var deps_dir = std.fs.cwd().openDir(deps_path, .{ .iterate = true }) catch continue;
^~~~
/usr/local/Cellar/zig/0.10.0/lib/zig/std/fs.zig:1640:32: note: struct declared here
pub const OpenDirOptions = struct {
^~~~~~
referenced by:
build: /Users/Vaughan/dev/fork/+bun/bun/build.zig:515:13
runBuild: /usr/local/Cellar/zig/0.10.0/lib/zig/build_runner.zig:231:32
remaining reference traces hidden; use '-freference-trace' to see all reference traces
/usr/local/Cellar/zig/0.10.0/lib/zig/std/build.zig:2314:31: error: deprecated; use addIncludePath
pub const addIncludeDir = @compileError("deprecated; use addIncludePath");
No longer failing
usockets error
See: https://discord.com/channels/876711213126520882/888839314056839309/1040680371282513921
Workaround
Used fix from: https://discord.com/channels/876711213126520882/1035092776901152778/1035097388941049926