oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
74.35k stars 2.78k forks source link

restore stubbed code paths in OutputFile.writeToDisk #15278

Open paperdave opened 2 days ago

paperdave commented 2 days ago

saw a crash report here. i cant believe none of our thousand bundler tests hit this. that makes me think this code path is only hit in some absurd legacy situation we should just delete. i've added a TODO comment on the union(enum).

later i want to ban @panic("TODO as a phrase in the codebase at all. it is terrible this was not caught.

regression from #14622

robobun commented 2 days ago

:x: @paperdave, your commit d08af32845586974e2b4aac238a643ec10b05aa8 has 15 failures in #6465:

  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64
  • test/cli/install/registry/bun-install-registry.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/timers-ordering.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/timers-ordering.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64-baseline
  • test/cli/install/bun-run.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/cli/hot/hot.test.ts - 1 failing on 🐧 12 aarch64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 aarch64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 13 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 14 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 13 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 14 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 x64-baseline