oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
74.35k stars 2.78k forks source link

remove optional ? from cli.zig #15298

Closed RiskyMH closed 1 day ago

RiskyMH commented 1 day ago

What does this PR do?

Speculative fix for cases like bun test --bail 10 where you actually need the = in between whitespace. I'm not sure I fully understand the reason for the ? option as there are many other flags that are optional but don't have it.

may fix #15293

How did you verify your code works?

CI will tell me

robobun commented 1 day ago

:x: @RiskyMH, your commit 2a5f8c5eba14653dbabc909cea939d6ddeceb5c9 has 20 failures in #6510:

  • test/cli/install/registry/bun-install-registry.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/integration/next-pages/test/dev-server.test.ts - 1 failing on 🐧 3.20 x64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 aarch64
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64-baseline
  • test/v8/v8.test.ts - 22 failing on 🐧 3.20 x64
  • test/bundler/bundler_compile.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-link.test.ts - 4 failing on 🐧 3.20 x64
  • test/js/web/fetch/fetch.tls.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/node/fs/fs.test.ts - timeout on 🐧 12 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/node/child_process/child_process.test.ts - timeout on 🐧 2023 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🐧 3.20 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64
  • test/cli/run/run-crash-handler.test.ts - timeout on 🐧 2023 x64-baseline
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 12 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/http/serve.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 aarch64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 11 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 12 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 20.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 2023 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64-baseline
  • test/js/node/test/parallel/fs-watch-recursive-linux-parallel-remove.test.js - 1 failing on 🐧 3.20 x64
  • test/integration/next-pages/test/next-build.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/node/test/parallel/timers-ordering.test.js - 1 failing on 🐧 22.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 14 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🪟 2019 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🪟 2019 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 13 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 12 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 11 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 20.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 22.04 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 aarch64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 2023 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 x64-baseline
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🐧 3.20 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 13 x64
  • test/js/bun/util/fuzzy-wuzzy.test.ts - segmentation fault on 🍎 14 x64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 aarch64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64
  • test/bundler/cli.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🍎 14 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🪟 2019 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 11 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 11 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 12 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🍎 13 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 11 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🐧 3.20 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🍎 13 x64
  • test/js/third_party/body-parser/express-bun-build-compile.test.ts - 1 failing on 🍎 14 x64
  • test/cli/hot/hot.test.ts - timeout on 🍎 14 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🪟 2019 x64
  • test/cli/hot/hot.test.ts - timeout on 🍎 13 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🪟 2019 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 11 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 20.04 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 12 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 11 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 20.04 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 12 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 2023 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64
  • test/cli/hot/hot.test.ts - timeout on 🐧 12 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 11 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 20.04 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 2023 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 aarch64
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64-baseline
  • test/cli/hot/hot.test.ts - timeout on 🐧 3.20 x64
  • test/cli/hot/hot.test.ts - timeout on 🍎 13 x64
  • test/cli/hot/hot.test.ts - timeout on 🍎 14 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🍎 14 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🪟 2019 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🪟 2019 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 12 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 11 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 12 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 11 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 22.04 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 20.04 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 2023 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🍎 13 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 2023 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 11 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 3.20 aarch64
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 2023 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 3.20 x64-baseline
  • test/cli/test/bun-test.test.ts - 1 failing on 🐧 3.20 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🍎 14 x64
  • test/cli/test/bun-test.test.ts - 1 failing on 🍎 13 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🍎 14 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🪟 2019 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🪟 2019 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 11 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 12 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 22.04 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 20.04 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 12 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 11 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 22.04 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 20.04 x64
  • test/cli/install/bun-run.test.ts - timeout on 🐧 2023 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🍎 13 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 2023 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 11 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 20.04 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 12 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 22.04 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 3.20 aarch64
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 2023 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 3.20 x64-baseline
  • test/cli/install/bun-run.test.ts - 2 failing on 🐧 3.20 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🍎 14 x64
  • test/cli/install/bun-run.test.ts - 2 failing on 🍎 13 x64
  • Electroid commented 1 day ago

    If we remove the ?, it would be a behaviour change. For example, --inspect with no arguments would not work

    RiskyMH commented 1 day ago

    this is very bad change after consideration