Open Jarred-Sumner opened 1 year ago
@Jarred-Sumner @colinhacks would it be possible for @faire to put a bounty on this? node-canvas
is the last holdout for us adopting bun install
in our frontend monorepo. bun would save us a lot of time in local dev & CI. https://github.com/oven-sh/bun/issues/5835#issuecomment-1943009418
(some of our testing deps link node_canvas
: mocha
, jsdom
, jest-environment-jsdom
)
@Jarred-Sumner @colinhacks would it be possible for @Faire to put a bounty on this?
node-canvas
is the last holdout for us adoptingbun install
in our frontend monorepo. bun would save us a lot of time in local dev & CI. #5835 (comment)
node-canvas already has an NAPI port, you just need to build the latest from the git. Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.
node-canvas already has an NAPI port, you just need to build the latest from the git. Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.
we don't depend on canvas
ourselves. some of our dependencies try to link it during the installation process (mocha
, jsdom
, jest-environment-jsdom
, ...) is there a way to get these dependencies to use the NAPI version?
Any updates when we can expect this to land?
node-canvas already has an NAPI port, you just need to build the latest from the git. Alternatively, you can use https://github.com/Brooooooklyn/canvas, which is faster and has basically the same API.
we don't depend on
canvas
ourselves. some of our dependencies try to link it during the installation process (mocha
,jsdom
,jest-environment-jsdom
, ...) is there a way to get these dependencies to use the NAPI version?
@chriskrogh Yes if you are willing to do some messy postinstall scripting, would be much easier if bun supported some nested overriding but that is also not in the roadmap afaik.
@Jarred-Sumner gentle bump here. seems like both this issue (and related ones https://github.com/oven-sh/bun/issues/5835) have been racking up reactions. any plans on adding this to bun sometime soon?
Please 🙏🏻
@Jarred-Sumner gentle bump here. seems like both this issue (and related ones #5835) have been racking up reactions. any plans on adding this to bun sometime soon?
node-canvas literally works fine. instead of telling Bun to update, tell those mfs to publish a release, because they haven't done that in forever.
This is blocking:
node-canvas
bcrypt
~better-sqlite3
These (and others like uWebSocket.js) use the V8 APIs instead of the cross-runtime n-api (which bun already implement)
We can probably look at node-jsc to see how to do this.