Vexcited
commented
1 year ago This is a solution I found for/with him, after chatting on Discord, had a similar issue with WebSockets that I solved the same way
So basically, we simply make our own request from scratch using the node:tls (or node:net) module.
By doing this way, it fully works and gives the result expected.
import tls from "node:tls";
const create_headers = (path: string, headers: Record<string, string>, body = ""): string => {
const head = [
`GET ${path} HTTP/1.1`,
// Add every items from the headers object.
...Object.entries(headers).map(([key, value]) => `${key}: ${value}`),
"", // There's a linebreak between the headers and the request's body.
body
];
return head.join("\r\n");
};
const request = (url: URL, options = {
method: "GET",
headers: {},
body: ""
}) => new Promise<string>((resolve, reject) => {
const port = url.protocol === "https:" ? 443 : 80;
const socket = tls.connect(port, url.hostname);
socket.on("data", (message: Buffer) => {
const response = message.toString("utf8");
resolve(response);
socket.end();
})
socket.on("connect", () => {
socket.write(create_headers(url.pathname + url.search, options.headers, options.body))
});
});
const url = new URL("https://..../profiles");
const response = await request(url, {
method: "GET",
body: "",
headers: {
Host: url.host,
Authorization: "Bearer XXXXXXXXX"
},
});
const body = response.split("\r\n\r\n")[1];
const json = JSON.parse(body);
console.log(json);We don't know the reason for the fetch issue, yet, but it would be cool if anyone could investigate on this (wonder if it's related or not with my issue https://github.com/oven-sh/bun/issues/4529)
jzila
Jarred-Sumner
What version of Bun is running?
1.0.0+ea56182c5a45be7978de8521f6cdaee0e0772434
What platform is your computer?
Linux 5.15.90.1-microsoft-standard-WSL2 x86_64 x86_64
What steps can reproduce the bug?
Steps to Reproduce the Bug:
fetch("xxx", { "headers": { "Authorization": "xxx", "User-Agent": "xxx" } }).then(response => response.text()).then(json => console.log(json))Bug Explanation: When performing the fetch request with the 'Authorization' header included, Bun returns a response with an empty body, which has a size of 0 KB. This behavior is unexpected and not in line with the normal behavior of other HTTP client libraries and tools like Node.js fetch, Python, PHP, and curl.
The bug appears to be specific to Bun when handling requests with the 'Authorization' header. It results in an incomplete response, making it impossible to retrieve the expected data from the server when authentication is required.
What is the expected behavior?
The expected behavior is to receive a response from the server with the correct body data. The response body should contain the data or content that corresponds to the requested URL and authentication credentials, allowing the script to process and utilize the received information as needed.
What do you see instead?
Instead of receiving the expected response with the relevant data, when using Bun to make a fetch request with the 'Authorization' header included, the observed behavior is as follows:
In summary, the issue with Bun is that it returns an empty response body (0 KB) when the 'Authorization' header is used, which is not the expected behavior for a functioning HTTP client.
Additional information