oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
74.48k stars 2.78k forks source link

Alias `install.save-exact` to `install.exact` in bunfig.toml #5405

Open Kleywalker opened 1 year ago

Kleywalker commented 1 year ago

What is the problem this feature would solve?

Always save dependencies exact when added.

What is the feature you are proposing to solve the problem?

Add save-exact option to bunfig.toml

What alternatives have you considered?

.npmrc save-exact https://docs.npmjs.com/cli/v8/commands/npm-install#save-exact

johnowennixon commented 1 year ago

I would like to second this request.

ottodevs commented 1 year ago

I also second this request, for now it seems to be documented here, but slightly different: https://bun.sh/docs/runtime/bunfig#install-exact (exact = true, instead of save-exact = true)

I would like suggest to change it to save-exact = true for consistency with other package managers like npm or pnpm, that is just a personal preference.

I also tested adding that to my bunfig.toml config and at least on my end is not working, it just keeps adding the caret ^ to the intalled packages, unless I add --exact as cli option on install.

I tested it with bun versions 1.0.0 and 1.0.2

Kleywalker commented 1 year ago

As soon as this works with bunfig.toml it works for me. exact is fine.

cj1128 commented 1 year ago

Any update? exact = true still does not work in bun 1.0.7.

Kleywalker commented 1 year ago

Is there a way to tag this issue as bug?

Kleywalker commented 1 year ago

This issue still exists in version 1.0.8

Kleywalker commented 1 year ago

This bug is not fixed in version 1.0.10

Kleywalker commented 1 year ago

This issue still exists in version 1.0.14

jedrichards commented 1 year ago

@Kleywalker Maybe you should edit this ticket to make it clear the feature has been added, but does not work? At the moment it might be being ignored because it sounds like you're requesting an existing feature - the topic of the ticket only changes in the comment thread.

Kleywalker commented 12 months ago

Created a new bug issue here

dylan-conway commented 1 month ago

Bun supports install.exact in bunfig.toml (https://bun.sh/docs/runtime/bunfig#install-exact).

Updated the title of this issue to make it clear this feature is already implemented.