Open bkniffler opened 11 months ago
We'd have to think about if this is worth implementing, since it could have a performance impact. (it tracks all promises) However, even if it is feasible, it's not a high priority.
@Electroid Is there any update on this?
Sadly the Temporal Typescript SDK does not work without createHook 😩
I'd love to have it at least as an opt-in if the performance impact is big.
Ping @lorensr
What's the status on this? Is an implementation of createHook
planned?
I'm the author of the code you linked in the Temporal TypeScript SDK.
Promise hooks are optional, they allow us to capture the stack trace of all running functions in a workflow.
I'm not sure if there's more of a gap for running our SDK on top of Bun but we can look into it.
Apart from promise hooks, we use Node's vm
and worker_threads
modules, AsyncLocalStorage
, and rely heavily on Rust Neon bindings.
What is the problem this feature would solve?
When trying to use temporal sdk (https://github.com/temporalio/sdk-typescript), getting error
Its used right here: https://github.com/temporalio/sdk-typescript/blob/3ce098be042e86d26ea5b433508a480503cb09b2/packages/worker/src/workflow/vm-shared.ts#L198
What is the feature you are proposing to solve the problem?
Implement createHook.
What alternatives have you considered?
Ask temporal to not use createHook, but probably out of reach since its needed to isolate the VM scope.