Remove dependency on `unzip` in `bun upgrade`

oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one

https://bun.sh

Other

73.01k stars 2.66k forks source link

Remove dependency on `unzip` in `bun upgrade` #7732

Open jjwallace opened 8 months ago

jjwallace commented 8 months ago

What version of Bun is running?

1.0.15

What platform is your computer?

Linux 6.2.0-39-generic x86_64 x86_64

What steps can reproduce the bug?

Run Command bun upgrade

What is the expected behavior?

upgrade bun to v1.0.18

What do you see instead?

error: Failed to locate "unzip" in PATH. bun upgrade needs "unzip" to work.

Additional information

Everything is up to date and also unzip is instlaled.

sudo apt install zip
sudo apt install unzip

Electroid commented 8 months ago

When you try to run unzip in your terminal, does it work?

paperdave commented 8 months ago

tbh why does bun upgrade depend on unzip. we should move away from this in the future, as we already statically link libarchive?

yMoutella commented 8 months ago

There's a solution for this problem? I'm facing this issue as well.

Liz-Lovelace commented 8 months ago

same issue on version 1.0.20 ubuntu :hand:

4Furki4 commented 8 months ago

I just installed Bun five days ago and wanted to upgrade it to 1.0.21 (bc It doesn't work at all, cannot use bun run dev) Even though it used unzip to install itself a couple of days ago, it no longer can use unzip to upgrade itself.

bozzhik commented 8 months ago

same issue on version 1.0.20 ubuntu ✋

i also have this issue

hedaukartik commented 7 months ago

Did anyone got the solution for this?

scffs commented 7 months ago

Did anyone got the solution for this?

Maybe u should try

sudo apt update
sudo apt-get install unzip

scffs commented 7 months ago

But...

ItsJustTomDev commented 7 months ago

So, I had the same issue but I managed to solve it.

For me it was a permission issue, I just changed to root and it worked then. My guess is that unzip is in the ROOT path, and not in your normal user path, so bun can't access it and doesnt see it there.

So try to upgrade via root, it worked for me :)

tnraro commented 4 months ago

I encountered the same problem as well. After seeing the comment above mentioning that root privileges are required, I recalled that I installed bun-js using Snapcraft. I assume I would have faced a similar issue if I had installed it using apt.

Try upgrading using the package manager you used, instead of bun upgrade.

Zaczero commented 3 months ago

Why does the release process depend on .zip? Using .tar.gz would result in a more painless procedure.

github-actions[bot] commented 4 weeks ago

This issue is stale and may be closed due to inactivity. If you're still running into this, please leave a comment.

Jarred-Sumner commented 4 weeks ago

This shouldn't have been tagged with "needs repro", the reproduction is run bun upgrade on a machine that doesn't have unzip in path