search

oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
73.26k stars 2.69k forks source link

Fix failing test in Bun.stringWidth #8329

Open Jarred-Sumner opened 8 months ago

Jarred-Sumner commented 8 months ago

Bun.stringWidth is disabled because the following test case fails

https://github.com/oven-sh/bun/blob/a8ff7be642a3cd93e033b324cfd1fc966b69af12/test/js/bun/util/stringWidth.test.ts#L87-L94

jdalton commented 8 months ago

Something to consider is folks like Sindre and Mathias B are on top of Unicode changes each year. It's a thing to babysit (maybe schedule period reminders to update/sync):

https://github.com/sindresorhus/get-east-asian-width/tree/main?tab=readme-ov-file#get-east-asian-width https://github.com/sindresorhus/string-width/commit/97b50e835636dcf15db098ec1614e34874ead0f9 https://github.com/chalk/ansi-regex/blob/main/index.js

Context: https://github.com/oven-sh/bun/commit/b82656d9fc34674fb248c883ad6cbe3c14bc6bd7