oven-sh / bun

Incredibly fast JavaScript runtime, bundler, test runner, and package manager – all in one
https://bun.sh
Other
73.48k stars 2.71k forks source link

LightMyRequest: undefined is not an object (evaluating 'response._header.match') #8358

Open psteinroe opened 8 months ago

psteinroe commented 8 months ago

What version of Bun is running?

latest

What platform is your computer?

I am running the ci on macOS and ubuntu.

What steps can reproduce the bug?

bun is still not supporting light my request. check out this pr for a reproduction.

its related to #7485 I think.

 172 |   response._lightMyRequest.headers = Object.assign({}, response.getHeaders())
  173 | 
  174 |   // Add raw headers
  175 |   ;['Date', 'Connection', 'Transfer-Encoding'].forEach((name) => {
  176 |     const regex = new RegExp('\\r\\n' + name + ': ([^\\r]*)\\r\\n')
  177 |     const field = response._header.match(regex)
                          ^
  TypeError: undefined is not an object (evaluating 'response._header.match')
        at /home/runner/work/fastify-supabase/fastify-supabase/node_modules/light-my-request/lib/response.js:177:19
        at forEach (:1:21)
        at copyHeaders (/home/runner/work/fastify-supabase/fastify-supabase/node_modules/light-my-request/lib/response.js:175:4)
        at /home/runner/work/fastify-supabase/fastify-supabase/node_modules/light-my-request/lib/response.js:65:3
        at /home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/error-handler.js:42:9
        at fallbackErrorHandler (/home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/error-handler.js:127:3)
        at handleError (/home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/error-handler.js:34:5)
        at onErrorHook (/home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/reply.js:777:5)
        at /home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/reply.js:145:5
        at preValidationCallback (/home/runner/work/fastify-supabase/fastify-supabase/node_modules/fastify/lib/handleRequest.js:87:5)

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response

jdalton commented 8 months ago

PR https://github.com/oven-sh/bun/pull/7659