ovenslove / vue-mdEditor

基于VUE的markdown文本编辑器
485 stars 106 forks source link

发现源码中对props传入的false值判断有BUG #4

Open Imprevia opened 7 years ago

Imprevia commented 7 years ago

源码中的data data() { return { input: this.mdValuesP || '', editStatus: this.editStatusP || true, previewStatus: this.previewStatusP || true, fullPageStatus: this.fullPageStatusP || false, navStatus: this.navStatusP || true, icoStatus: this.icoStatusP || true, maxEditScrollHeight:0, maxPreviewScrollHeight:0 } }, 以editStatus为例: this.editStatusP的值为false editStatus的值为true this.editStatusP的值为true editStatus的值为true editStatus的值一直为true

ovenslove commented 7 years ago

谢谢你的提醒:

<markdown 
            :mdValuesP="msg.mdValue"  
            :fullPageStatusP="false" 
            :editStatusP="false" 
            :previewStatusP="false" 
            :navStatusP="false"
            :icoStatusP="true"  
            @childevent="childEventHandler"
></markdown>

中的属性值判断有误,修改为以下代码:

            return {
                input: this.mdValuesP || '',
                editStatus: Boolean(this.editStatusP),
                previewStatus: Boolean(this.previewStatusP),
                fullPageStatus: Boolean(this.fullPageStatusP),
                navStatus: Boolean(this.navStatusP),
                icoStatus: Boolean(this.icoStatusP),
                maxEditScrollHeight:0,
                maxPreviewScrollHeight:0
            }

使用Boolean()去将数据转化为true或者false. 谢谢你意见。